[Web Bluetooth] Add Read descriptors sample #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beaufortfrancois
force-pushed
the
readClientCharacteristicConfiguration
branch
from
2349fb1
to
0802f6b
Compare
scheib
reviewed
Jan 30, 2017
| await descriptor.readValue().then(value => { | ||
| log('> Client Characteristic Configuration:'); | ||
| log(' > Notifications: ' + (value.getUint8(0) ? 'ON' : 'OFF')); | ||
| log(' > Indications: ' + (value.getUint8(1) ? 'ON' : 'OFF')); |
There was a problem hiding this comment.
This is fetching the 2nd byte, but you intended to select the 2nd bit. Use something like:
value.getUint8(0) & 0b01 // notifications
value.getUint8(0) & 0b10 // indications
There was a problem hiding this comment.
Rookie mistake. Thanks for catching this @scheib
ES6 binary notation to the rescue!
|
@scheib WDYT? |
|
For info, I've just submitted a PR at rouge-ruby/rouge#619 to make ES6 Binary literals and Octal literals highlighting works. |
scheib
approved these changes
Jan 31, 2017
|
Links giving me nothing but 404 pages someone give me a BLE Bluetooth link or download access please |
|
You can find all samples at https://googlechrome.github.io/samples/web-bluetooth/index.html |
markafoltz
pushed a commit
that referenced
this pull request
Oct 14, 2024
* [Web Bluetooth] Add Read descriptors sample * Fix byte/bit mistake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a more advanced sample for reading Bluetooth GATT descriptors.
R: @scheib
You can try it live at:
https://beaufortfrancois.github.io/samples/web-bluetooth/read-descriptors.html
https://beaufortfrancois.github.io/samples/web-bluetooth/read-descriptors-async-await.html
https://beaufortfrancois.github.io/samples/web-bluetooth/index.html